Skip to content

Implement TODO in test_ast.py #102797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Eclips4 opened this issue Mar 17, 2023 · 1 comment · Fixed by #102798
Closed

Implement TODO in test_ast.py #102797

Eclips4 opened this issue Mar 17, 2023 · 1 comment · Fixed by #102798
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@Eclips4
Copy link
Member

Eclips4 commented Mar 17, 2023 •
edited by bedevere-bot
Loading

In test_ast.py we have a old TODO:

cpython/Lib/test/test_ast.py

Lines 266 to 267 in 72186aa

# TODO: expr_context, slice, boolop, operator, unaryop, cmpop, comprehension
# excepthandler, arguments, keywords, alias

How I understand, it says about code snippets in exec_tests and eval_tests.
So, I've decide to improve it.

Linked PRs
@Eclips4 Eclips4 added the type-feature A feature request or enhancement label Mar 17, 2023
Eclips4 added a commit to Eclips4/cpython that referenced this issue Mar 17, 2023
@Eclips4
pythongh-102797: Add more code snipets for exec_tests and eval_tests
c3ce030
This was referenced Mar 17, 2023
Merged
Closed
@arhadthedev arhadthedev added the tests Tests in the Lib/test dir label Mar 23, 2023
vstinner pushed a commit that referenced this issue Jun 19, 2024
@Eclips4 @terryjreedy @nineteendo
gh-102797: Add more code snippets in test_ast (#102798)
b8fb369 
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Nineteendo <[email protected]>
@vstinner
Copy link
Member

Fixed by b8fb369.

mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@Eclips4 @terryjreedy
@nineteendo @mrahtz
pythongh-102797: Add more code snippets in test_ast (python#102798)
dd43ccd 
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Nineteendo <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@Eclips4 @terryjreedy
@nineteendo @noahbkim
pythongh-102797: Add more code snippets in test_ast (python#102798)
b5357fe 
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Nineteendo <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@Eclips4 @terryjreedy
@nineteendo @estyxx
pythongh-102797: Add more code snippets in test_ast (python#102798)
799a646 
Co-authored-by: Terry Jan Reedy <[email protected]>
Co-authored-by: Nineteendo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-102797: Add more code snippets for exec_tests and eval_tests Eclips4/cpython
3 participants
@vstinner @arhadthedev @Eclips4