Skip to content

Update readme with pip install instructions #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2017
Merged

Update readme with pip install instructions #130

merged 3 commits into from
Jun 19, 2017

Conversation

Mariatta
Copy link
Member

@Mariatta Mariatta commented Jun 19, 2017 •
edited
Loading

Closes #114

willingc
willingc reviewed Jun 19, 2017
View reviewed changes
cherry_picker/readme.rst Outdated

Specify an `upstream` remote in the cloned CPython repository::
Ensure that an ``upstream`` remote is specified in the cloned CPython repository::
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps split this into two steps:

Verify that an ``upstream`` remote is set to the CPython repository::
     $ git remote -v
     ...
     upstream	https://github.com/python/cpython (fetch)
     upstream	https://github.com/python/cpython (push)

If needed, create the ``upstream`` remote::
    $ git remote add upstream https://github.com/python/cpython.git

cherry_picker/readme.rst Outdated

$ git remote add upstream https://github.com/python/cpython.git


The cherry picking script assumes that if an `upstream` remote is defined, then
The cherry picking script assumes that if an ``upstream`` remote is defined, then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps move these 2 sentences before the "verifying upstream remote".

@Mariatta Mariatta mentioned this pull request Jun 19, 2017
Closed
@Mariatta
Copy link
Member Author

Thanks @willingc I made the suggested changes.

willingc
willingc approved these changes Jun 19, 2017
View reviewed changes
Copy link

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mariatta

@Mariatta Mariatta merged commit ff2fadb into python:master Jun 19, 2017
@Mariatta Mariatta deleted the pip-install branch June 19, 2017 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
cherry_picker.py CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mariatta @willingc @the-knights-who-say-ni