Skip to content

Close #390: Ignore !buildbot comment if no builder matches #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

vstinner
Copy link
Member

Also, match the regex anywhere in the builder name, not only at the start.

Also, match the regex anywhere in the builder name, not only at the
start.
@vstinner vstinner merged commit b3ee477 into python:main Sep 21, 2023
@vstinner vstinner deleted the pr_testing branch September 21, 2023 23:04
@vstinner
Copy link
Member Author

Ok, the change works as expected: python/cpython#109698 (comment)

I just made a typo, fixed by: 69e9ee1

@sentry-io
Copy link

sentry-io bot commented Sep 29, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NameError: name 'builder' is not defined custom.pr_testing in <listcomp> View Issue

Did you find this useful? React with a 👍 or 👎

@vstinner
Copy link
Member Author

‼️ NameError: name 'builder' is not defined custom.pr_testing in View Issue

I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant