Skip to content

Initial read-only support for notes, style objects #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Initial read-only support for notes, style objects #53

wants to merge 11 commits into from

Conversation

ludoo
Copy link

@ludoo ludoo commented May 20, 2014

I added initial support for footnotes/endnotes parts, and footnotes/endnotes references. The new classes are read-only, much in the same way the styles part is, as I only need to read existing documents.

I also added a style class with id/type/name attributes, to ease working with documents where style ids are radically different from style names.

I could not wrap my head around your testing framework, so I added basic nose tests in the notes_tests folder.

@ludoo ludoo mentioned this pull request May 20, 2014
@scanny
Copy link
Contributor

scanny commented May 29, 2014

Great @ludoo, thanks for this :)

@ludoo
Copy link
Author

ludoo commented May 29, 2014

Added a few stuff after actually starting to use this library in a project I'm writing to convert from docx to latex/html/whatever. Main changes:

  • accessing end/footnotes part properties return None if not relevant part is in the doc
  • support more than one end/footnote reference in a single run
  • add a method to cycle through run (textual) elements, and wrap them in classes

The last one is more a sketch than a useful implementation, but I really need something like this and doing it in the Run objects seems a more reusable solution.

@ZvikaZ
Copy link

ZvikaZ commented Jan 13, 2019

Hi.
Is there a change to merge this pull request?
It'd be very helpful...
Thanks

@cassidylaidlaw
Copy link

Any idea when this PR will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants