Skip to content

Apply custom_formatters on ANY-typed Schemas #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

phrfpeixoto
Copy link
Contributor

Proposed solution for #149

I've also refactored some tests, in addition to writing additional cases for using custom_formatters with objects.

@codecov
Copy link

codecov bot commented Jul 7, 2019

Codecov Report

Merging #150 into master will increase coverage by 0.25%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   96.19%   96.44%   +0.25%     
==========================================
  Files          58       58              
  Lines        1602     1603       +1     
==========================================
+ Hits         1541     1546       +5     
+ Misses         61       57       -4
Impacted Files Coverage Δ
openapi_core/schema/schemas/exceptions.py 86.44% <ø> (+3.38%) ⬆️
openapi_core/schema/schemas/models.py 97.28% <100%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e30b71...a6694f4. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 7, 2019

Codecov Report

Merging #150 into master will increase coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #150     +/-   ##
=========================================
+ Coverage   96.19%   96.69%   +0.5%     
=========================================
  Files          58       58             
  Lines        1602     1603      +1     
=========================================
+ Hits         1541     1550      +9     
+ Misses         61       53      -8
Impacted Files Coverage Δ
openapi_core/schema/schemas/exceptions.py 86.44% <ø> (+3.38%) ⬆️
openapi_core/schema/schemas/models.py 97.28% <100%> (+0.61%) ⬆️
openapi_core/compat.py 100% <0%> (+44.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e30b71...a6694f4. Read the comment docs.

@phrfpeixoto phrfpeixoto changed the title Custom Formatters only work on properties' custom_formatters do work unless the containing shema is strictly Object Jul 8, 2019
@phrfpeixoto phrfpeixoto changed the title properties' custom_formatters do work unless the containing shema is strictly Object Apply custom_formatters on ANY-typed Schemas Jul 8, 2019
@p1c2u
Copy link
Collaborator

p1c2u commented Feb 17, 2020

Rewritten unmarshalling process handles the case. Hence closing

@p1c2u p1c2u closed this Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants