Make pgettext search plurals when translation is not found #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
+ Coverage 90.99% 91.06% +0.06%
==========================================
Files 26 26
Lines 4444 4453 +9
==========================================
+ Hits 4044 4055 +11
+ Misses 400 398 -2 ☔ View full report in Codecov by Sentry. |
akx
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
LGTM, this exactly mirrors https://github.com/python/cpython/pull/107118/files 👍
pgettext can now find the following translation
when using `pgettext("ctx", "foo")`:
msgctxt "ctx"
msgid "foo"
msgid_plural "foos"
msgstr[0] "foo translated"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given this po file:
pgettextfails to find the singular translation i.e.pgettext("ctx", "foo") == "foo"when one would expect to getfoo translated.The same issue has already been fixed upstream in
gettext:python/cpython#62519
python/cpython#107118
This PR applies the same patch to babel.