Skip to content

Add pythnet quorum listener to hermes #2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Conversation

danimhr
Copy link
Contributor

@danimhr danimhr commented Jun 11, 2025

No description provided.

Copy link

vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 9:57am
component-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 9:57am
developer-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 9:57am
entropy-debugger ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 9:57am
entropy-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 9:57am
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 9:57am
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 9:57am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 9:57am

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering how you have tested this code.

Also, can you bump the version of Hermes? (maybe add an alpha to avoid people upgrading)

@danimhr
Copy link
Contributor Author

danimhr commented Jun 11, 2025

@ali-bahjati I ran Hermes, Pythnet-watcher, and quorum locally with a single guardian inside the guardian set, and override the guardian set list on my local with that specific guardian. Then connect these three services and created a log to see if Hermes could process VAA completely till the end or not.

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danimhr danimhr changed the title Add pythnet quorum listere to hermes Add pythnet quorum listener to hermes Jun 11, 2025
@danimhr danimhr merged commit 72bd8b9 into main Jun 11, 2025
13 checks passed
@danimhr danimhr deleted the feat/hermes-pythnet-quorum branch June 11, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants