Skip to content

Split relayer sessions into separate threads #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2025

Conversation

merolish
Copy link
Contributor

@merolish merolish commented Jun 5, 2025

This should mirror the changes in the new lazer agent (both of which should be refactored into common code).

.await
{
tracing::error!("Error sending transaction to Lazer relayer session: {e:?}");
// TODO: Under what circumstances would the channel be hosed and is it worth retry?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The channels are mpsc so I think the only way to receive error is if the channel is closed.

Copy link
Contributor

@keyvankhademi keyvankhademi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, wait for ali to approve

@merolish
Copy link
Contributor Author

merolish commented Jun 5, 2025

Thanks, going to make changes reflecting lazer agent review also.

@merolish merolish requested review from darunrs and ali-behjati June 7, 2025 13:26
Copy link
Contributor

@keyvankhademi keyvankhademi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's wait for @ali-bahjati to do the final review.

@merolish merolish marked this pull request as ready for review June 10, 2025 15:52
Base automatically changed from mike/lazer-update-1 to main June 10, 2025 15:57
let mut relayer_senders = vec![];

for url in config.relayer_urls.iter() {
let (sender, receiver) = mpsc::channel(RELAYER_CHANNEL_CAPACITY);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use a broadcast::channel here instead of managing multiple single consumer channels

Copy link
Collaborator

@ali-behjati ali-behjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address my comment before merging, and also don't forget to bump the version (if it's gonna be released)

@merolish
Copy link
Contributor Author

Refactored to broadcast::channel in most recent commit. Will bump version if I end up wanting to deploy to test without needing anything else.

@merolish merolish merged commit 9482f3d into main Jun 11, 2025
2 checks passed
@merolish merolish deleted the mike/lazer-relayer-threads branch June 11, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants