Fixes issue related to rerun attribute on report (Issue #77) #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallner
requested changes
Jan 7, 2019
There was a problem hiding this comment.
Thank you for the finding the regression and the respective solution and adding a changelog entry. I am afraid, with the current PR , we are not fixing the regression completely as 10a9df2 changed the value of i by one. Could you please take that into account?
pytest_rerunfailures.py
Outdated
| @@ -175,6 +175,7 @@ def pytest_runtest_protocol(item, nextitem): | |||
| reports = runtestprotocol(item, nextitem=nextitem, log=False) | |||
|
|
|||
| for report in reports: # 3 reports: setup, call, teardown | |||
| report.rerun = item.execution_count | |||
There was a problem hiding this comment.
To restore the old behaviour, I think we need to subtract from the execution_count.
Suggested change
| report.rerun = item.execution_count | |
| report.rerun = item.execution_count -1 |
| testdir.makeconftest(""" | ||
| def pytest_runtest_logreport(report): | ||
| assert hasattr(report, 'rerun') | ||
| assert isinstance(report.rerun, int) |
There was a problem hiding this comment.
Maybe we could assert the upper limit for reruns here.
Suggested change
| assert isinstance(report.rerun, int) | |
| assert isinstance(report.rerun, int) | |
| assert report.rerun <= 2 |
sallner
approved these changes
Jan 8, 2019
|
Thanks again for you contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I reported on #77