Add type annotations #340
Merged
Add type annotations #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
approved these changes
Jan 10, 2022
nicoddemus
approved these changes
Jan 11, 2022
| [tool.mypy] | ||
| mypy_path = "src" | ||
| check_untyped_defs = true | ||
| # disallow_any_expr = true |
There was a problem hiding this comment.
Should we add a comment explaining why this option is commented out? If not remove it?
|
Took the liberty of committing an update to coverage configuration to ignore typing-related code (c5d5786). |
|
Thanks for the reviews! I think this is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds type annotations to all pluggy code. This is a respin of #225 but now using Python 3 syntax.
The type annotations are not published, it will require some work for it to make sense, cleaning up the interface and imports and such. But I think internal type annotations are still useful for understand the code (I always have to relearn how stuff relate to each other when looking at pluggy) and as a linter.
In the meantime @RonnyPfannschmidt created #326. I think this PR is a better starting point because it almost doesn't change the code itself besides adding the types. Ronny's changes can be added on top maybe.