Skip to content

Implement support for PKCE #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ArtyomVancyan opened this issue Aug 23, 2023 · 0 comments · Fixed by #21
Closed

Implement support for PKCE #18

ArtyomVancyan opened this issue Aug 23, 2023 · 0 comments · Fixed by #21
Assignees
@ArtyomVancyan
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ArtyomVancyan
Copy link
Member

ArtyomVancyan commented Aug 23, 2023 •
edited
Loading

Implement support for PKCE. The oauthlib dependency of the library already has PKCE support, so it needs to handle the proper URL parameters. The documentation of oauthlib according to the PKCE usage can be found here.

challenge
@ArtyomVancyan ArtyomVancyan self-assigned this Aug 23, 2023
@ArtyomVancyan ArtyomVancyan converted this from a draft issue Aug 23, 2023
@ArtyomVancyan ArtyomVancyan added the enhancement New feature or request label Aug 23, 2023
@ArtyomVancyan ArtyomVancyan changed the title Add PKCE support (NEEDS RESEARCH) Implement support for PKCE Aug 28, 2023
@ArtyomVancyan ArtyomVancyan moved this from Todo to In Progress in fastapi-oauth2 Aug 28, 2023
@ArtyomVancyan ArtyomVancyan added the documentation Improvements or additions to documentation label Aug 28, 2023
@ArtyomVancyan ArtyomVancyan mentioned this issue Aug 28, 2023
Closed
ArtyomVancyan added a commit to ArtyomVancyan/fastapi-oauth2 that referenced this issue Aug 30, 2023
@ArtyomVancyan
pysnippetGH-18: Pass all URL params to oauthlib including PKCE ones
59b013c
@ArtyomVancyan ArtyomVancyan mentioned this issue Sep 1, 2023
Merged
6 tasks
@ArtyomVancyan ArtyomVancyan linked a pull request Sep 1, 2023 that will close this issue
Implement support for PKCE #21
Merged
6 tasks
ArtyomVancyan added a commit to ArtyomVancyan/fastapi-oauth2 that referenced this issue Sep 2, 2023
@ArtyomVancyan
pysnippetGH-18: Override default params with the provided ones
0be90fb
ArtyomVancyan added a commit to ArtyomVancyan/fastapi-oauth2 that referenced this issue Sep 3, 2023
@ArtyomVancyan
pysnippetGH-18: Add tests for the PKCE workflow
0ffac70
ArtyomVancyan added a commit to ArtyomVancyan/fastapi-oauth2 that referenced this issue Sep 6, 2023
@ArtyomVancyan
pysnippetGH-18: Write up the "PKCE support" section
7b5457f
@github-project-automation github-project-automation bot moved this from In Progress to Done in fastapi-oauth2 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtyomVancyan ArtyomVancyan

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
fastapi-oauth2
Status: Done
Milestone
No milestone
1 participant
@ArtyomVancyan