Prepare musllinux integration (CC #103) #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to figure out how to recognise musllinux hosts
Looks like platform.libc_ver()[0] currently just returns an empty string on musl: python/cpython#87414
mara004
commented
Apr 30, 2022
| @@ -49,6 +49,9 @@ def _copy_bindings(pl_name): | |||
| def _get_linux_tag(arch): | |||
| return 'manylinux_2_17_%s.manylinux2014_%s' % (arch, arch) | |||
|
|
|||
| def _get_musllinux_tag(arch): | |||
| return 'musllinux_1_2_%s' % (arch) | |||
There was a problem hiding this comment.
1_1 might work as well - not sure about this.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to properly recognise musl host systems in
setup.py(see python/cpython#87414).