Skip to content

feat: allow stubs package #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: allow stubs package #742

wants to merge 19 commits into from

Conversation

trim21
Copy link

@trim21 trim21 commented Apr 6, 2025

close #332

  • do not try to get docstring and version if it's not dynamic, which is typical the case of stubs package
  • do not raise exception if it's -stubs package without __init__.py
  • do not normalize the -stubs parts in package name

@trim21 trim21 marked this pull request as draft April 6, 2025 20:51
@trim21 trim21 marked this pull request as ready for review April 6, 2025 20:59
Copy link
Contributor

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @trim21! It will be a great addition to have. Left a few comments below.

Copy link
Contributor

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last comments

Copy link
Contributor

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @trim21! This looks good to me. Will wait a few more days before merging to give others the chance to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stub-only packages?
3 participants