Skip to content

bpo-41282: Load install schemes from sysconfig (port from CPython) #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

henryiii
Copy link

@henryiii henryiii commented Dec 21, 2021

In response to pypa/setuptools#2946.

Directly applying the changes from python/cpython#24549. No other testing at the moment.

@henryiii
Copy link
Author

Okay, guessing we will need pypy and pypy_nt added (@mattip, correct?). Also, "headers" is not present, but why isn't it triggering on "include"? That error (on 3.6) is weird. @frenzymadness, perhaps?

Also, shouldn't any PR to distutils in CPython automatically be requested to make a PR here?

@mattip
Copy link
Contributor

mattip commented Dec 21, 2021

Yes, PyPy 3.7 still needs pypy and pypy_nt. PyPy 3.8+ no longer does, we changed to the cpython layout schema (still using implementation and implementation_lower though).

@jaraco
Copy link
Member

jaraco commented Dec 21, 2021

Also, shouldn't any PR to distutils in CPython automatically be requested to make a PR here?

Yes, probably. I wasn't fully grasping the implications of the changes to CPython when I reviewed it. My (incorrect) assessment was that the changes to stdlib were primarily removing functionality toward deprecation and that this project could adopt those changes as needed/desired. I agree, changes to CPython should be ported here.

@jaraco
Copy link
Member

jaraco commented Dec 21, 2021

Now I worry I may really have confused things with my analysis in pypa/setuptools#2946.

A few things:

@jaraco
Copy link
Member

jaraco commented Dec 23, 2021

Apologies for the bad advice on the relevant PR, but distutils has diverged from cpython/distutils in this effort, so I'm going to close.

@jaraco jaraco closed this Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants