Bugfix/tests for msvc spawn #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me platforms. Allows unit testing of module on non-Windows platforms.
… spawn call does not simply fail to execute. Ref pypa/setuptools#2257.
…ATH environment variable. Fixes failing test and fixes pypa/setuptools#2257.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pypa/setuptools#2257, I learned that the test for the fix introduced in #6 was inadequate and that although the test did catch race conditions with the old implementation, it failed to catch a regression in the patched implementation. This approach goes further and ensures that the tests fail when the spawn command does not run as expected and then fixes two flaws in the implementation.