Implement numpy-like Rayleigh distribution #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 80.80% 80.81%
=======================================
Files 162 162
Lines 46816 46822 +6
Branches 11454 11455 +1
=======================================
+ Hits 37832 37838 +6
Misses 6735 6735
Partials 2249 2249
|
ricardoV94
requested changes
May 7, 2024
ricardoV94
changed the title
ricardoV94
reviewed
May 8, 2024
pytensor/tensor/random/basic.py
Outdated
| Scale parameter of the distribution (positive). Default is 1.0. | ||
| size : int or tuple of ints, optional | ||
| Output shape. If the given shape is, e.g., `(m, n, k)`, then `m * n * k` samples | ||
| are drawn. Default is None, in which case a single value is returned. |
There was a problem hiding this comment.
This is wrong. Is it what the other docstrings write? If not provided the size is implied by the shape of scale
There was a problem hiding this comment.
No this is a error on my side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorporate
Rayleighdistribution as square root ofchi2distribution with degree of freedom 2.As per the reference.
Related Issue
Checklist
Type of change