-
Notifications
You must be signed in to change notification settings - Fork 135
Implement numpy-like Rayleigh distribution #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 80.80% 80.81%
=======================================
Files 162 162
Lines 46816 46822 +6
Branches 11454 11455 +1
=======================================
+ Hits 37832 37838 +6
Misses 6735 6735
Partials 2249 2249
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small tweak and need for docstrings
pytensor/tensor/random/basic.py
Outdated
Scale parameter of the distribution (positive). Default is 1.0. | ||
size : int or tuple of ints, optional | ||
Output shape. If the given shape is, e.g., `(m, n, k)`, then `m * n * k` samples | ||
are drawn. Default is None, in which case a single value is returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. Is it what the other docstrings write? If not provided the size is implied by the shape of scale
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is a error on my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
Incorporate
Rayleigh
distribution as square root ofchi2
distribution with degree of freedom 2.As per the reference.
Related Issue
Checklist
Type of change