Pull windows deps on update in meson buildconfig #3500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-mesonpy-improve
branch
from
68c6115 to
9a13d0e
Compare
Starbuck5
approved these changes
Jun 15, 2025
There was a problem hiding this comment.
I'd become pretty quick at deleting them so it would reinstall by default, but this requires less manual work. Thanks Ankith!
I had thought the real solution is to not hardcode SDL versions in the windows build code, because it should be fine installing on an older version. But this way all our Windows contributors will stay synced on a version depending on what commit they're on, which seems good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a pull would happen only if the whole prebuilts directory didn't exist. Now the logic has been improved to check for exact expected versions and handle pull accordingly