Fix ascii scrap on sdl2 backend, docs/tests fixes #3473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-scrap-fixes
branch
from
7e91c13 to
7e8d9e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we all know scrap is deprecated, why this PR?
Well, my initial goal was to simply skip all the failing tests on non-windows platforms and call it a day, but then I realised that we broke
"text/plain"AKApygame.SCRAP_TEXTsupport in pygame-ce when it is trivial to support in our current SDL2 scrap backend (which already supports"text/plain;charset=utf-8").Of the 5 failing tests, simple updates to our sdl2 scrap backend fixes 2 tests on all non windows platforms. I added skips to the rest on non windows platforms, and also removed an interactive test that was testing for removed x11 backend functionality.
And finally, I updated the docs to reflect reality. The docs currently claim a lot of things we don't support, and this may tempt a few users to use it ignoring the deprecation warnings. Our current scrap status is simply "plain text is supported on all platforms, images/music may work on windows".