Skip to content

Port over more SDL functions to SDL3 #3451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025

Conversation

Starbuck5
Copy link
Member

This PR handles SDL_LockSurface and SDL_FillRect.

This is a prerequisite to #3435, since that one is giving me warnings (that I don't get locally) related to these functions.

This is similar to #3434

@Starbuck5 Starbuck5 requested a review from a team as a code owner May 31, 2025 10:05
@Starbuck5 Starbuck5 added the sdl3 label May 31, 2025
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the inline strategy to avoid having conditional preprocessives all over the place convoluting the code. LGTM!

@Starbuck5 Starbuck5 force-pushed the sdl3-moar-functions branch from 0e23dc7 to 1ff8759 Compare May 31, 2025 10:22
Copy link
Member

@MightyJosip MightyJosip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you defined all the modified functions, and change conditions the right way with the SDL3 (from == 0 to != 0, and other alternatives)

👍

@Starbuck5
Copy link
Member Author

Starbuck5 commented May 31, 2025

(Just force pushed to rebase)

I like the inline strategy to avoid having conditional preprocessives all over the place convoluting the code. LGTM!

And they're all in the SDL3 style, so in the future when we only support SDL3 we can just switch PG_ to SDL_.

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.5.5 milestone May 31, 2025
@ankith26 ankith26 merged commit 88834fa into pygame-community:main May 31, 2025
27 checks passed
@Starbuck5 Starbuck5 deleted the sdl3-moar-functions branch May 31, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants