-
-
Notifications
You must be signed in to change notification settings - Fork 423
Add .gitattributes to prevent CRLF issues on WSL (#508) #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Will this actually help? Other files read by shell scripts will also have bogus CRLFs in them. And the main executable script don't have extensions at all! You need to rather checkout the repo with |
Thanks for the thoughtful feedback! You're absolutely right — this My intention here was to address one of the most frequent problems reported by WSL users, where That said, I agree that documenting Let me know what direction you'd prefer! |
Pyenv-Virtualenv has only one |
Thanks for clarifying — you're right, I didn't realize that pyenv-virtualenv itself has no actively used Instead, I'd be happy to open a follow-up PR to update the README with a note for WSL/Windows users recommending Let me know if that sounds good! |
Documenting How do they primarily install Pyenv in WSL? |
Thanks for the clarification — that makes sense. I installed pyenv and pyenv-virtualenv manually (via So I think having a brief WSL-specific note in the README could still be helpful for users not relying on Let me know if you'd prefer the README note as a standalone section or just a short warning under the Installation section — I can update this PR accordingly. |
I reckon a "WSL note:" before the |
Thanks for the thoughtful discussion and guidance! You're absolutely right — since this change doesn't actually affect any files in this repository, and I'll follow up shortly with a new PR that adds a WSL note in the README as suggested. Appreciate your help in finding the right direction! 🙌 |
Confirmed that pyenv-installer already handles this more safely using -c core.autocrlf=false, so no further action needed there. |
This PR adds a
.gitattributes
file that enforces LF line endings for shell scripts.This resolves an issue where WSL users may encounter:
/usr/bin/env: ‘bash\r’: No such file or directory
This PR addresses Issue #508
Summary
.sh
scripts are checked out with LF even on Windows