Ensure xplt.FacetGrid works on Dataset objects #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great. I'll give this a review later today. Side note: I think we're going to have a few merge conflicts after #608. |
|
Yes, this will certainly need a rebase after #608 (which we should merge first). |
shoyer
force-pushed
the
facet-dataset
branch
2 times, most recently
from
8251cf9 to
61c2414
Compare
This, along with the ``.map`` method, provides a much more generally
flexible API for making plots. It still needs some examples for the docs.
Here's something simple with synthetic data:
ds = xray.Dataset({'x': np.linspace(0, 10),
'y': [1, 2, 3],
'foo': ('x', np.random.randn(50)),
'bar': ('x', np.random.rand(50))})
ds *= ds.y
(xplt.FacetGrid(ds, col='y')
.map(plt.plot, 'x', 'foo')
.map(plt.scatter, 'x', 'bar', color='green'))
|
@jhamman any comments here? |
|
@shoyer - I just had a look through this. I don't have any significant comments. I think you merge this. |
shoyer
added a commit
that referenced
this pull request
Oct 26, 2015
Ensure xplt.FacetGrid works on Dataset objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, along with the
.mapmethod, provides a much more generally flexible API for making plots.It still needs some examples for the docs. Here's something simple with synthetic data: