MAINT: Refactor more compat checks into compat init #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
May 8, 2017
| PANDAS_0160 = (PANDAS_VERSION >= LooseVersion('0.16.0')) | ||
|
|
||
| if PANDAS_0190: | ||
| from pandas.api.types import is_number |
There was a problem hiding this comment.
You do see how PANDAS_0190 is defined?
|
minor change ping when ready |
I already addressed in the diff (see how I defined |
|
ahh i c |
|
thanks! ideally can get the tests working (or maybe xfail the ones that are not) |
|
I think #303 is intending to do that, but I'm not sure whether or not progress will be made yet to actually fix the tests themselves. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory.
xref #309.