Skip to content

Better fix for gh-239 #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2017
Merged

Better fix for gh-239 #243

merged 1 commit into from
Jan 28, 2017

Conversation

avalentino
Copy link
Contributor

distutils.LooseVersion does not handle correctly RC versions

@avalentino
Better fix for pydatagh-239
5156cd5 
distutils.LooseVersion does not handle correctly RC versions
@FrancescAlted
Copy link
Contributor

Good point. We will need to use parse_version() instead of LooseVersion() in all places then?

@FrancescAlted
Copy link
Contributor

Oops, just checked that that was the only place where LooseVersion() was used. Merging!

@FrancescAlted FrancescAlted merged commit 3e1ad29 into pydata:master Jan 28, 2017
@avalentino avalentino deleted the issue-239b branch February 13, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avalentino @FrancescAlted