-
Notifications
You must be signed in to change notification settings - Fork 175
add support for free-threaded wheels #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe we intentionally wanted to build against python.org Python's, but I absolutely do not remember why. Do you @reaperhulk ? |
Maybe related to the note about MacOS here and the difference in behavior on Python < 3.11? I'd need to figure out how to trigger a free-threaded install using the installer, but happy to switch it back if that was a load-bearing choice :) |
Probably macOS SDK compatibility, although I don’t recall if there was another reason. |
I couldn't figure out a way to include the necessary plist file into the actions workflow definition directly, so I added |
All the plist manipulation is cribbed from @colesbury's PR adding free-threading support to |
I think the test failure is unrelated |
I think is ready for another pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this before. THanks!
@@ -0,0 +1,14 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, sorry should have caught this before: can you this to .github/config/macos-pkg-choices-freethreaded.xml
(i.e. not in workflows
)?
See this actions run on my fork.
Let me know if using
setup-python
on MacOS is problematic for some reason.Fixes #913.