Skip to content

maint(clang-tidy): Enable cpp-coreguideline slicing checks #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 23, 2021
Merged

maint(clang-tidy): Enable cpp-coreguideline slicing checks #3210

merged 4 commits into from
Aug 23, 2021

Conversation

Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Aug 21, 2021 •
edited
Loading

Description

  • This enable an additional clang-tidy check that checks for potentially bugprone inheritance slicing behavior and automatically warns if it is encountered. There is only one class the currently exhibits this behavior, and this PR fixes this potentially buggy behavior.

Suggested changelog entry:

* Enable clang-tidy check to guard against inheritance slicing

@Skylion007 Skylion007 requested review from rwgk and henryiii August 21, 2021 18:51
@Skylion007 Skylion007 changed the title maint(clang-tidy): Enable cpp-coreguideline slicing checkg maint(clang-tidy): Enable cpp-coreguideline slicing checks Aug 21, 2021
henryiii
henryiii reviewed Aug 23, 2021
View reviewed changes
README.rst
@@ -134,9 +134,9 @@ About
This project was created by `Wenzel
Jakob <http://rgl.epfl.ch/people/wjakob>`_. Significant features and/or
improvements to the code were contributed by Jonas Adler, Lori A. Burns,
Sylvain Corlay, Eric Cousineau, Ralf Grosse-Kunstleve, Trent Houliston, Axel
Sylvain Corlay, Eric Cousineau, Aaron Gokaslan, Ralf Grosse-Kunstleve, Trent Houliston, Axel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rwgk
rwgk approved these changes Aug 23, 2021
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Skylion007!

@Skylion007 Skylion007 merged commit 6cbabc4 into pybind:master Aug 23, 2021
@Skylion007 Skylion007 deleted the clang-tidy-slicing branch August 23, 2021 22:42
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 23, 2021
rwgk added a commit to rwgk/pybind11 that referenced this pull request Aug 26, 2021
@rwgk
Adding NOLINT related to pybind#3210
c8953eb
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Sep 16, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @rwgk @henryiii