Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that this pull request:
npm run lint
)Fixes #123
Things to note:
I tried to test everything, but it looks like there is no cases that
state.ide.infiniteLoop
is ever set in the code - there is adetectInfiniteLoops
action creator but it is never used. Looks like this was dropped here: 58d0dba#diff-78f15da1e797d1c04ac443d4af43a757L35I guess the question is, is that state variable dead code or should that be re-added in?