Skip to content

Refactor Nav Props - See #824 #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

meiamsome
Copy link
Member

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Noting that I'm not using Fixes, so that the issue can be worked on over multiple PRs.

I think it makes sense to PR these refactors individually because the diffs will become quite unclear and big fairly quickly, so here is one refactoring. Let me know if you'd prefer me to do a bunch of them in one PR and I'll do that.

@catarak
Copy link
Member

catarak commented Feb 25, 2019

i definitely prefer smaller PR's, so keep doing the small ones!

i think this refactoring will also help with breaking up some of the components—a few of them are very large 😄

@catarak
Copy link
Member

catarak commented Feb 25, 2019

tested all of the nav functionality and it's working for me!

@catarak catarak merged commit 61f20d1 into processing:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants