Skip to content

refactor: use graphql-request dep #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 29, 2020
Merged

Conversation

jasonkuhrt
Copy link
Member

@jasonkuhrt jasonkuhrt commented May 28, 2020

This removes code that essentially inlined the graphql-request library. It was originally inlined to circumvent graffle-js/graffle#26 which is now fixed.

TODO

  • docs

@jasonkuhrt jasonkuhrt requested a review from Weakky May 28, 2020 01:46
@jasonkuhrt
Copy link
Member Author

Hm, not quite working out yet. I'll finish debugging over the next few days.

@jasonkuhrt jasonkuhrt marked this pull request as draft May 28, 2020 03:57
@jasonkuhrt
Copy link
Member Author

Just awaiting publish rights now https://github.com/prisma-labs/graphql-request/runs/719048786 now.

@jasonkuhrt jasonkuhrt marked this pull request as ready for review May 29, 2020 03:23
@jasonkuhrt
Copy link
Member Author

@Weakky other than the missing published package this is ready for review. Example of it working on local linked hello-world:

image

Copy link
Collaborator

@Weakky Weakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonkuhrt jasonkuhrt merged commit eb471b2 into master May 29, 2020
@jasonkuhrt jasonkuhrt deleted the refactor/graphql-request-dep branch May 29, 2020 13:53
kazazes pushed a commit to kazazes/nexus that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants