feat(context): analyze addToContext under all import styles #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Weakky still some work to do but feedback welcome. |
jasonkuhrt
commented
Jul 13, 2020
src/lib/tsc.ts
Outdated
| if (sourceFile.getFilePath().includes('node_modules')) continue | ||
| let entry: ModulesWithImportSearchResult | ||
| for (const importDec of sourceFile.getImportDeclarations()) { | ||
| if (importDec.getModuleSpecifier().getText() === `'${id}'`) { |
There was a problem hiding this comment.
A bonus of this new approach is that we'll have better perf. We used to analyze all source files, even if they didn't import nexus. Not sure how many real-world cases will see improvement, but for some larger apps I could see this being a not-nothing improvement.
|
Status: debugging this issue dsherret/ts-morph#835 |
This reverts commit 785898d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1222
TODO