Skip to content

fix: reintroduce source-map support #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2020
Merged

fix: reintroduce source-map support #1195

merged 1 commit into from
Jul 8, 2020

Conversation

Weakky
Copy link
Collaborator

@Weakky Weakky commented Jul 8, 2020

closes #1107

I don't remember why we ditched ts-node but I don't see the point so far. We're keeping it in our dependencies regardless to enable folks to run their prisma seed script. Maybe ts-node should only be part of the prisma plugin. Point is, it's a very light dependency anyway and it prevents issues like the one I just fixed.

This PR re-enables pretty traces used in nexus-plugin-prisma.

TODO

  • docs
    • jsdoc
    • website api
    • website guides
    • website tutorial
  • tests

Copy link
Member

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I opted to not use ts-node internally to stay closer to the metal and not have some parts using ts-node while others not. We need to own our TS experience and I don’t understand all the things ts-node is or isn’t doing.

@Weakky Weakky merged commit 3faae6c into master Jul 8, 2020
@Weakky Weakky deleted the fix/source-maps branch July 8, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source maps are not preserved when transpiling
2 participants