Add docker_image mirroring #238
Open
+84
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horstage
commented
May 20, 2025
| @@ -68,7 +68,7 @@ def git(*cmd: str) -> None: | |||
| # Commit and tag | |||
| git('add', '.') | |||
| git('commit', '-m', f'Mirror: {version}') | |||
| git('tag', f'v{version}') | |||
| git('tag', f'v{version}' if language != 'docker_image' else version) | |||
There was a problem hiding this comment.
This may be a controversial decision, but I want to keep the git tags in sync with the docker tags.
There was a problem hiding this comment.
This files overwrites the all/.pre-commit-hooks.yaml. It think that's nice and intuitive, but depends on this line to stay in that order.
Horstage
commented
May 20, 2025
Comment on lines
+261
to
+268
| def test_docker_image_integration_official_repo(in_git_dir): | ||
| make_repo( | ||
| '.', | ||
| language='docker_image', name='python', description='', | ||
| entry='python', id='python-docker', match_key='files', | ||
| match_val=r'\.py$', args='[]', require_serial='false', | ||
| minimum_pre_commit_version='0', | ||
| ) |
There was a problem hiding this comment.
Not really a valid pre-commit hook, but there are so few in the official repo 🤷
Also this is a good, but time consuming test for the pagination requests.
|
before you spend more time on this I think there needs to be a little more discussion:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.