-
Notifications
You must be signed in to change notification settings - Fork 13
Make topics a "tag/label" system instead of a "category" system #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jchampio do you wanna assign yourself here? Also for future reference, some of my thoughts on this from a thread on discord:
|
@JelteF I think I need collaborator permission first, but yes. |
Apparently it was enough for you to respond here for me to be allowed to add you as the assignee. |
A tag/label feature is a high priority for me but I wouldn't expect or try to replace the existing Topic model; though tweaking the available topics is on the table. I would go with tags but I'd be pressed to explain why. |
A Tag is an arbitrary label for a patch in the Commitfest UI. Other than helping users identify patches of interest, it has no other semantic meaning to the CF application. This addresses #11 and #67. Tags are created using the administrator interface. They consist of a unique name and a background color. The color should be sent from compliant browsers in `#rrggbb` format, which is stored without backend validation; to avoid later CSS injection, any non-conforming values are replaced with black during rendering. It also includes some javascript to help admins pick colors that aren't completely eye-gouging, by putting up an (ignorable) warning if we don't meet baseline [WCAG recommendations](https://www.w3.org/WAI/WCAG22/Techniques/general/G18.html) on text contrast. ## Notes - To avoid putting a separate name+color copy of every tag into each row of the `patchlist` query, I instead grab the tag IDs and look them up in a map at render time. I think this requires `@transaction.atomic` to tie the map and patches together, which I've added across the entire view for simplicity. - Backend validation for the color didn't make a whole lot of sense to me, since only admins can create tags and we escape at time-of-use anyway. ## Screenshots Admin interface:  User interface:  --------- Co-authored-by: Jelte Fennema-Nio <[email protected]>
Often patches fall in multiple of the topics. So we should replace it with a many-to-many system as opposed to a many-to-one relationship. We should probably also rename it to "tag" instead of "topic". These changes would allow us to add many more useful labeling, like "good-first-review".
The text was updated successfully, but these errors were encountered: