karma/jamsine plot interaction tests #61
Conversation
- this test outputs random pixel from run-to-run, skip for now.
| @@ -54,6 +54,9 @@ function testMock (fileName, t) { | |||
| // TODO fix race condition in gl2d image generation | |||
| if(fileName.indexOf('gl2d_') !== -1) return; | |||
|
|
|||
| // TODO fix run-to-run randomness | |||
| if(fileName === 'gl3d_bunny-hull.json') return; | |||
There was a problem hiding this comment.
this particular 3d mock fails in ~ 1 out of 10 attempts.
There was a problem hiding this comment.
can we make an issue for this and embed the issue number in this comment?
This reverts commit 8f28b80.
- exclude that test file on circleci runs - that way, gl plot interactions can be tested locally
| var files = fs.readdirSync(constants.pathToTestImageMocks); | ||
|
|
||
| // -1 for font-wishlist and | ||
| // -38 for the gl2d mocks | ||
| t.plan(files.length - 39); | ||
| // -1 for gl3d_bunny-hull |
There was a problem hiding this comment.
does this mean files.length -1 for bunny-hull? Perhaps we can expand this comment with a little more description.
There was a problem hiding this comment.
more like files.length -1 - 38 - 1 = files.length - 40
There was a problem hiding this comment.
but yeah, I can make this clearer
|
this is great, really nice work getting Plotly integration tests going. There are just a few places we should add a little more commentary and issue linkages so everyone is on the same page. Once those 🐄 's are done its 💃 from me! |
karma/jamsine plot interaction tests
@alexcjohnson @bpostlethwaite @cldougl @mdtusz
Turns out the karma runner can generate plotly.js graphs in a test browser. 🎉