Destroy modebar in purge step #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdtusz if you're up for it, this might a good time to a
|
|
|
|
@perigee the tests don't seem to be running properly on circle - I'm guessing this may be related to the changes you had made yesterday evening? |
|
@mdtusz I restarted the tests, and things work. CircleCI had a bad day yesterday. |
| ]; | ||
|
|
||
| Plotly.Plots.purge(gd); | ||
| expect(Object.keys(gd)).toEqual(expectedKeys); |
There was a problem hiding this comment.
@mdtusz great test 🎉 thanks for doing this.
|
10 seconds of adding code, 30 minutes of hoping the jasmine test would finish without disconnecting... 2 seconds to review. 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10 seconds of adding code,
30 minutes of hoping the jasmine test would finish without disconnecting...
From issue #120