This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Deleting unused proptype ConfirmDialog.key #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So there's a test for this but it's still not clear what if anything it does. |
nicolaskruchten
force-pushed
the
nicolaskruchten-patch-2
branch
from
a97bfbc to
b6ee7ff
Compare
nicolaskruchten
changed the title
|
Would we be worried about some apps built that use this? Should I just add a "Deprecated, doesn't do anything" description instead? |
alexcjohnson
approved these changes
Apr 30, 2019
nicolaskruchten
force-pushed
the
nicolaskruchten-patch-2
branch
from
b6ee7ff to
07ff5db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't seem to be read or written anywhere