Skip to content

Add bundler ecosystem extension #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 15, 2023
Merged

Add bundler ecosystem extension #1182

merged 9 commits into from
Aug 15, 2023

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Aug 10, 2023

Closes #1178.

@cd-work cd-work requested a review from a team as a code owner August 10, 2023 22:25
@cd-work cd-work requested a review from maxrake August 10, 2023 22:25
kylewillmon
kylewillmon previously approved these changes Aug 11, 2023
Copy link
Contributor

@kylewillmon kylewillmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need some testing (which I believe @maxrake is currently doing), but the code looks good now.

Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local testing was performed with some limitations. The Phylum processing pipeline was delayed beyond the 30 minutes advertised and therefore it was not possible to see the full results of some phylum bundle add commands. More local testing will be performed after the requested changes are addressed.

It would also be nice if this extension included tests, like how the poetry extension does.

Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local testing was performed and the extension worked as expected for the install, add, and update commands.

There is still a question about the remove command, which is not covered but does install gems. The README says:

When invoking phylum bundle, subcommands that would install gems will trigger a Phylum analysis first.

Adding the remove command for coverage or creating a new issue for it and any other affected ecosystem extensions is requested.

It would also be nice if this extension included tests, like how the Poetry extension does.

@cd-work
Copy link
Contributor Author

cd-work commented Aug 14, 2023

There is still a question about the remove command, which is not covered but does install gems.

This wouldn't be difficult, but should be made a consistent policy if we want to enforce it. Bundle also has an option to not install packages on remove for example.

It would also be nice if this extension included tests, like how the Poetry extension does.

The poetry extension tests have never provided anything but trouble to me. I didn't write them and I wasn't ever a fan of them. So I have no intention of adding more for this extension.

Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest changes were confirmed with local testing. LGTM.

@cd-work cd-work merged commit 3154eb9 into main Aug 15, 2023
@cd-work cd-work deleted the gem_precheck branch August 15, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Official gem extension
3 participants