Skip to content

Update RedisCluster signatures #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.1.x
Choose a base branch
from
Open

Update RedisCluster signatures #4045

wants to merge 2 commits into from

Conversation

RobiNN1
Copy link

@RobiNN1 RobiNN1 commented Jun 5, 2025

@ondrejmirtes
Copy link
Member

Hey, this is too many changes and it's impossible to review. What actual bugs are you experiencing?

We could also remove these entries altogether and just rely on phpstorm-stubs. "Reflection golden test" workflow will tell us what actual data would change.

@RobiNN1
Copy link
Author

RobiNN1 commented Jun 5, 2025

I added changes from from JetBrains/phpstorm-stubs@348c656

The current signatures are outdated, and more than 50 functions are missing. It was outdated in phpstorm stubs and here too

@RobiNN1
Copy link
Author

RobiNN1 commented Jun 5, 2025

I'm working on new PR and tried to keep the original parameter names, but the difference is still huge. The old signatures of many functions don't even have defined return types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants