json_last_error_msg - better message - error position near by #18866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-morales
changed the title
| case PHP_JSON_ERROR_UNSUPPORTED_TYPE: | ||
| case PHP_JSON_ERROR_INVALID_PROPERTY_NAME: | ||
| case PHP_JSON_ERROR_UTF16: | ||
| spprintf(&final_message, 0, "%s near character %zu",error_message, JSON_G(error_pos)); |
There was a problem hiding this comment.
missing space
Suggested change
| spprintf(&final_message, 0, "%s near character %zu",error_message, JSON_G(error_pos)); | |
| spprintf(&final_message, 0, "%s near character %zu", error_message, JSON_G(error_pos)); |
| @@ -340,6 +350,7 @@ PHP_JSON_API void php_json_parser_init_ex(php_json_parser *parser, | |||
| int max_depth, | |||
| const php_json_parser_methods *parser_methods) | |||
| { | |||
|
|
|||
There was a problem hiding this comment.
unrelated whitespace addition, please remove
| @@ -26,6 +26,7 @@ struct _php_json_encoder { | |||
| int depth; | |||
| int max_depth; | |||
| php_json_error_code error_code; | |||
| size_t error_pos; | |||
There was a problem hiding this comment.
please indent to match the other lines
| @@ -29,12 +29,14 @@ typedef struct _php_json_scanner { | |||
| php_json_ctype *marker; /* marker position for backtracking */ | |||
| php_json_ctype *ctxmarker; /* marker position for context backtracking */ | |||
| php_json_ctype *str_start; /* start position of the string */ | |||
| php_json_ctype *input_start; /* start position of the string */ | |||
There was a problem hiding this comment.
please document the difference between str_start and input_start rather than just repeating the same documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working POC giving a better error message when the
json_last_error_msgfunction is called (only for this function).Putting aside my bad C coding skill, I would like to know your opinions on this PR, and kindly ask for reviews in order to improve it.
Thx in advance.
(@bukka I know you have been working on a new parser, but ... until that reaches the surface, could we go this way? (with the proper adjustments for sure)