Skip to content

Remove driver specific support from ODBC #15727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Remove driver specific support from ODBC #15727

wants to merge 6 commits into from
+17 −579

Conversation

NattyNarwhal
Copy link
Member

@NattyNarwhal NattyNarwhal commented Sep 3, 2024 •
edited
Loading

See GH-15630 for motivation and some concerns. Looks like we can get rid of a bunch of ifdefs!

Additional ones I've had since this:

  • Should we remove the Db2 special casing?
  • There's some redundancy with the various fetch functions; this could be made into a common interface that the PHP functions call into.
  • It seems fetch hash works with all the driver managers, but not the custom ones.
  • SQL_TIMESTAMP is gated behind Adabas for some reason (in odbc_bindcols), even though it seems general? May need to look into how it gets converted to SQL_C_CHAR per ODBC ref.
  • HAVE_SQLDATASOURCES only gets set on Windows, need to test or assume on Unix ahahaha accidentally deleted it in a cleanup, added back

NattyNarwhal
NattyNarwhal commented Sep 3, 2024
View reviewed changes
cmb69
cmb69 reviewed Sep 6, 2024
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I'm all for removing legacy cruft, especially early in the "new" master branch (i.e. in a couple of weeks). I can barely comment on the Unix specialties, though.

@cmb69 cmb69 mentioned this pull request Jan 25, 2025
Draft
@NattyNarwhal
Purge most special cases for building ODBC with specific drivers
f7fde67 
PDO_ODBC doesn't do this, and most of these drivers are not in use with
PHP, at least like this. Chances are these expose an ODBC driver you can
use with a normal driver manager like unixODBC or iODBC. If not, it can
be specified as a custom driver, though it does not include any
workarounds.

There might be some redundant definitions now as a result.

IBM Db2 is kept as a special case due to it also being in PDO_ODBC,
though I wonder how good of an idea this is.

See phpGH-15630
@NattyNarwhal
Remove never used include
b4252e0 
This would only be used on 68k classic Mac OS. Did PHP ever run there?
@NattyNarwhal
Fold HAVE_SQL_EXTENDED_FETCH
8f9c41d 
All supported driver managers can do extended fetches.
@NattyNarwhal
Ope, accidentally deleted this in a refactor
38d9adc
@NattyNarwhal
All driver managers support SQLDataSources now too
4f84174 
So we don't need the define?
@NattyNarwhal
Remove undef CHAR
de911c2 
There's no justification behind as to why this should be.
@NattyNarwhal
Copy link
Member Author

Rebased this; I also suspect ODBCVER checks can probably be removed since Windows and the Unix ODBC driver managers are all 0x350 minimum.

@NattyNarwhal NattyNarwhal marked this pull request as ready for review June 10, 2025 18:06
@NattyNarwhal NattyNarwhal requested a review from kocsismate as a code owner June 10, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@petk petk Awaiting requested review from petk

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Category: Build System Extension: odbc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NattyNarwhal @cmb69