-
-
Notifications
You must be signed in to change notification settings - Fork 19
Added PHPUnit 6.5 to Travis CI config #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
df3ac2f
Test against PHP 7.2
michalbundyra 2cd36d4
Test with PHPUnit 6.5
michalbundyra 719d58d
Fixed PHPUnit 6.5 support
michalbundyra 125f3d9
Fixed autoloading interface
michalbundyra a684fae
Check if method getParameters exists, and if so use it
michalbundyra 57c41e6
Use reference to params
michalbundyra ac4854c
Use MockObject
michalbundyra 773b035
Just in case play safe on updating parameters...
michalbundyra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
<?php | ||
|
||
if (! interface_exists(\PHPUnit\Framework\MockObject\Matcher\Invocation::class)) { | ||
class_alias( | ||
\PHPUnit_Framework_MockObject_Matcher_Invocation::class, | ||
\PHPUnit\Framework\MockObject\Matcher\Invocation::class | ||
); | ||
} | ||
|
||
if (! interface_exists(\PHPUnit\Framework\MockObject\Invocation::class)) { | ||
class_alias( | ||
\PHPUnit_Framework_MockObject_Invocation::class, | ||
\PHPUnit\Framework\MockObject\Invocation::class | ||
); | ||
} | ||
|
||
if (! interface_exists(\PHPUnit\Framework\MockObject\MockObject::class)) { | ||
class_alias( | ||
\PHPUnit_Framework_MockObject_MockObject::class, | ||
\PHPUnit\Framework\MockObject\MockObject::class | ||
); | ||
} | ||
|
||
if (! class_exists(\PHPUnit\Framework\MockObject\Builder\InvocationMocker::class)) { | ||
class_alias( | ||
\PHPUnit_Framework_MockObject_Builder_InvocationMocker::class, | ||
\PHPUnit\Framework\MockObject\Builder\InvocationMocker::class | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nice as a work around but not sustainable. Relying on implementation details can break at any upstream patch release. I try to get a public interface for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was the only possible solution in current situation. If the public interface change then we can improve this part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know. I just wanted to give you some context why I closed this PR so that you won't get frustrated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's your library, you can do whatever you want ! :)
I would consider release v2.1 with support PHPUnit 6.5+ only and everyone will be happy 😄
Of course, still there will be the same issue, and only reflection will be the way to that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that's still a little fuck up. Unfortunaltey I have to make a further 2.0 release which supports 6.5 otherwise 2.0 is broken.