Update react adapter to v4 #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WyriHaximus
commented
Nov 14, 2022
WyriHaximus
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | php-http/react-adapter#50, php-http/react-adapter#56, php-http/react-adapter#57, and php-http/react-adapter#58 |
| Documentation | if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation |
| License | MIT |
|
@dbu As promised, here is the docs PR. |
dbu
reviewed
Nov 14, 2022
clients/react-adapter.rst
Outdated
| @@ -76,6 +64,18 @@ Or send asynchronous ones:: | |||
| // Returns a Http\Promise\Promise | |||
| $promise = $adapter->sendAsyncRequest(request); | |||
|
|
|||
| Note that since v4 calling `wait` on `Http\Promise\Promise` is expected to ran inside a fiber:: | |||
There was a problem hiding this comment.
Suggested change
| Note that since v4 calling `wait` on `Http\Promise\Promise` is expected to ran inside a fiber:: | |
| Note that since v4 calling `wait` on `Http\Promise\Promise` is expected to run inside a fiber:: |
|
thanks for updating the doc! just a typo i think, otherwise looks good |
WyriHaximus
force-pushed
the
update-react-adapter-to-v4
branch
from
1c891df to
dd3d5f2
Compare
|
Updated 👍 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.