Added fallback on common classes. Puli is now optional #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make Puli optional as discussed in #55.
This is how discovery works
Step 1) Use puli,
Step 2) See if we find any HttpClients
Step 3) Look for Guzzle factories, will succeed if
php-http/message
andguzzlehttp/psr7
is installedStep 4) Look for Diactoros factories, will succeed if
php-http/message
andzendframework/zend-diactoros
is installedChanges:
\RuntimeException
anymore. There will be aNotFoundException
.NotFoundException
is moved fromHttp\Discovery
toHttp\Discovery\Exception
TODO
This is just a proof of concept. Do we like to go this way?