Skip to content

chore: bump dependencies #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 4, 2025
Merged

chore: bump dependencies #189

merged 8 commits into from
Mar 4, 2025

Conversation

nimish-ks
Copy link
Member

Bumped rich, keyring and questionary.

@nimish-ks nimish-ks self-assigned this Mar 1, 2025
@rohan-chaturvedi
Copy link
Member

@nimish-ks It seems like cffi=1.15.1 is failing to build with python 3.13:

python-cffi/cffi#23

Building wheels for collected packages: cffi
  Building wheel for cffi (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Building wheel for cffi (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [43 lines of output]
      running bdist_wheel
      running build
      running build_py
      creating build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/__init__.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/api.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/backend_ctypes.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/cffi_opcode.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/commontypes.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/cparser.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/error.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/ffiplatform.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/lock.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/model.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/pkgconfig.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/recompiler.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/setuptools_ext.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/vengine_cpy.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/vengine_gen.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/verifier.py -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/_cffi_include.h -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/parse_c_type.h -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/_embedding.h -> build/lib.linux-x86_64-cpython-313/cffi
      copying cffi/_cffi_errors.h -> build/lib.linux-x86_64-cpython-313/cffi
      running build_ext
      building '_cffi_backend' extension
      creating build/temp.linux-x86_64-cpython-313/c
      gcc -fno-strict-overflow -Wsign-compare -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -fexceptions -fcf-protection -fexceptions -fcf-protection -fexceptions -fcf-protection -O3 -fPIC -DFFI_BUILDING=1 -DUSE__THREAD -DHAVE_SYNC_SYNCHRONIZE -I/home/ascendance/Documents/phase/cli/.venv/include -I/usr/include/python3.13 -c c/_cffi_backend.c -o build/temp.linux-x86_64-cpython-313/c/_cffi_backend.o
      c/_cffi_backend.c: In function ‘b_do_dlopen’:
      c/_cffi_backend.c:4523:22: warning: ‘Py_FileSystemDefaultEncoding’ is deprecated [-Wdeprecated-declarations]
       4523 |                      Py_FileSystemDefaultEncoding, &filename_or_null, &flags))
            |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      In file included from /usr/include/python3.13/Python.h:99,
                       from c/_cffi_backend.c:2:
      /usr/include/python3.13/fileobject.h:22:46: note: declared here
         22 | Py_DEPRECATED(3.12) PyAPI_DATA(const char *) Py_FileSystemDefaultEncoding;
            |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      c/_cffi_backend.c: In function ‘_my_PyErr_WriteUnraisable’:
      c/_cffi_backend.c:6112:9: error: implicit declaration of function ‘_PyErr_WriteUnraisableMsg’; did you mean ‘PyErr_WriteUnraisable’? [-Wimplicit-function-declaration]
       6112 |         _PyErr_WriteUnraisableMsg(PyText_AS_UTF8(s), NULL);
            |         ^~~~~~~~~~~~~~~~~~~~~~~~~
            |         PyErr_WriteUnraisable
      error: command '/usr/bin/gcc' failed with exit code 1
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for cffi
Failed to build cffi

Upgrading to cffi=1.17.1 seems to fix the build and everything works, but not sure if it will break anything else. Perhaps we can bump it just in dev_requirements.txt to not break the CI?

@rohan-chaturvedi rohan-chaturvedi self-requested a review March 4, 2025 15:08
@nimish-ks nimish-ks merged commit 875b704 into main Mar 4, 2025
13 checks passed
@nimish-ks nimish-ks deleted the chore--bump-dependencies branch March 4, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants