feat(CC-batch-2): added batch 2 #11828
Conversation
|
Preview: https://patternfly-react-pr-11828.surge.sh A11y report: https://patternfly-react-pr-11828-a11y.surge.sh |
mattnolting
force-pushed
the
feat-CC-batch-2
branch
from
c125345 to
a2c8176
Compare
| props: { | ||
| children: figma.children('*') | ||
| }, | ||
| example: (props) => <AlertGroup>{props.children}</AlertGroup> |
There was a problem hiding this comment.
this AlertGroup should have isToast isLiveRegion hasAnimations added to it
| // children | ||
| children: figma.children('*') | ||
| }, | ||
| example: (props) => <AlertGroup>{props.children}</AlertGroup> |
There was a problem hiding this comment.
These AlertGroups should have isLiveRegion and hasAnimations if they could appear on the page. They don't need these props if they are present on page load and cannot be dismissed.
| disabled: true | ||
| }) | ||
| }, | ||
| example: (props) => <Badge title={props.title} isRead={props.isRead} isDisabled={props.isDisabled} /> |
There was a problem hiding this comment.
There is no title prop on Badge. instead you pass the title as children
There was a problem hiding this comment.
It may also be worth stubbing out the screenReaderText prop for a11y setup.
| children: figma.children('*') | ||
| }, | ||
| example: (props) => ( | ||
| <Alert variant={props.variant} title={props.title} variantLabel={props.variant} isInline isPlain /> |
There was a problem hiding this comment.
Do we need separate code connect files for inline alert & plain inline alert or could these be combined with boolean flags for both isPlain and isInline?
| disabled: true | ||
| }) | ||
| }, | ||
| example: (props) => <Badge title={props.title} isRead={props.isRead} isDisabled={props.isDisabled} /> |
There was a problem hiding this comment.
It may also be worth stubbing out the screenReaderText prop for a11y setup.
Relates to: #11624
Included components:
Component tracker
Figma preview
Resources: