Skip to content

RecyclerView QueryAdapter + Example #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

RecyclerView QueryAdapter + Example #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ad09631
Added RecyclerView.Adapter adapter; sample project
Sep 2, 2015
2167b5b
removed view types
Sep 4, 2015
82a2510
removed some 'this.'
Sep 4, 2015
0887422
cleaned up example
Sep 9, 2015
ebb8a8b
- updated appcompat dependencies (gradle)
Sep 9, 2015
cb4c494
fixed build
Sep 10, 2015
84571e4
changed package and renamed class
Sep 11, 2015
e8ebe87
added tests
Sep 12, 2015
8ff2888
updated sample app
Sep 15, 2015
9d0576b
removed parse keys
Sep 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ParseLoginUI/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ dependencies {
compile 'com.android.support:support-v4:22.0.0'
compile 'com.parse:parse-android:1.10.1'

compile 'com.android.support:appcompat-v7:22.0.0'
compile 'com.android.support:recyclerview-v7:22.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to make these provided so that they're not required if they're not using these helpers, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use provided but it doesn't build.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm... I don't like the fact that we're requiring these when developers might not be utilizing ParseQueryAdapter... Why not leave as provided and have the same use compile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use provided but it didn't compile.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what target didn't compile? and i had a typo: why not leave this as provided and the sample/example compile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I use provided then connectedDebugAndroidTest fails with java.lang.NoClassDefFoundError: com.parse.widget.ParseQueryAdapter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add compile dependencies to androidTest by using androidTestCompile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using androidTestCompile and adding androidTestCompile and provided, both doesn't work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm grab me sometime tomorrow and we can check out what's going on, but it should work with provided and androidTestCompile

provided 'com.facebook.android:facebook-android-sdk:4.0.1'
provided files("$rootProject.projectDir/ParseLoginUI/libs/ParseFacebookUtilsV4-1.10.1.jar")
provided files("$rootProject.projectDir/ParseLoginUI/libs/ParseTwitterUtils-1.10.1.jar")
Expand Down
Loading