[rlp] fix nested unbounded lists #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
commented
Aug 26, 2019
| @@ -335,6 +334,7 @@ impl RlpStream { | |||
| let len = self.buffer.len() - list.position; | |||
| self.encoder().insert_list_payload(len, list.position); | |||
| self.note_appended(1); | |||
| self.finished_list = true; | |||
dvdplm
approved these changes
Aug 26, 2019
| @@ -326,7 +325,7 @@ impl RlpStream { | |||
| BasicEncoder::new(self) | |||
| } | |||
|
|
|||
| /// Finalize current ubnbound list. Panics if no unbounded list has been opened. | |||
| /// Finalize current unbounded list. Panics if no unbounded list has been opened. | |||
| pub fn complete_unbounded_list(&mut self) { | |||
There was a problem hiding this comment.
Unrelated, but maybe this should be called finalize_unbounded_list()?
There was a problem hiding this comment.
Both sounds fine to me, but I'm not a native speaker. Also, I'd like to avoid breaking changes.
There was a problem hiding this comment.
"complete" can be both the imperative form of the verb as in "complete your homework before dinner!" or be and adjective "a complete list of my belongings".
"finalize" does not have this ambiguity.
In this context the ambiguity makes it unclear if the method returns an unbounded list of something that is complete, or that it takes an unbounded list and completes it.
We can add a copy named finalize_unbounded_list and deprecate this one. In another PR.
niklasad1
approved these changes
Sep 4, 2019
ordian
pushed a commit
that referenced
this pull request
Sep 5, 2019
* master: [plain_hasher] Migrate to 2018 edition (#213) [ethbloom] Improve ethbloom (#215) [rlp] fix nested unbounded lists (#203) stabilize parity-bytes in no_std environment (#212) Speed up hex serialization, support Serde `with`, and fix warnings (#208) [ethbloom, ethereum-types,kvdb] migrate to 2018 edition (#205) Introduce `ContractAddress` newtype instead of scheme enum (#200)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105.