-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
docfix: add boolean array as option for indexing with .iloc #8970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
is out-of-bounds, except *slice* indexers which allow out-of-bounds indexing. | ||
(this conforms with python/numpy *slice* semantics). Allowed inputs are: | ||
- ``.iloc`` is primarily integer position based (from ``0`` to | ||
``length-1`` of the axis), but may also be used with a boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
their is another section at the very top of indexing.rst where .iloc/.loc
are described similarly. pls add there as necessary as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it the Different Choices and the Selection By Position sections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I hope this is what you were referring to. Tried to make minimal changes as necessary.
@cswarth can you update to the comments? |
not sure what you need for in an update - I was just getting back to this when you mail came in. I'll modify other doc sections on |
@cswarth their are 2 mentions of the iloc description (one at the very top and one where you modified). Need them both to be the same. Nothing additional is necessary w.r.t. what you wrote. |
merged via 7be0236 thanks! |
resolves #8956 Trivial documentation addition of boolean array as option for .iloc