DOC: clean up 0.14.1 whatsnew file #7714
Conversation
| .. _whatsnew_0141.prior_deprecations: | ||
| - Previously, the behaviour on resetting the time or not in | ||
| ``offsets.apply``, ``rollforward`` and ``rollback`` operations differed | ||
| between offsets. With the introduction of the ``normalize`` keyword (see |
There was a problem hiding this comment.
well normalize was always their; this was a bug that it was not being passed on (so still API change)
There was a problem hiding this comment.
"With the introduction of .. " -> "Wit the support of the normalize keyword for all offsets" -> better?
There was a problem hiding this comment.
I just rewrote this a bit, because how is was previously (I copied the original to enhancements), it was not clear to me what actually changed (and so in which way people's code could be affected/have to be changed)
|
something wrong with the rendering here: http://pandas-docs.github.io/pandas-docs-travis/cookbook.html#aliasing-axis-names (it cuts off for some reason)....can you take a look? thxs |
|
I think I fixed it with 9d71aae (just a temp fix, should look more into it as it is probably a bug in the ipython directive) |
|
interesting, so function definitions not handled properly....ok! |
|
Hmm, not as such, eg http://pandas-docs.github.io/pandas-docs-travis/enhancingperf.html#pure-python it renders OK, so it should still be a slightly different issue. But in any case, my hack should let it render OK. |
|
@jreback Should there be som 'highlights'? (also for in the release message)
|
|
sure that would be gr8! |
|
Other things you think of? |
|
maybe perf improv |
|
updated |
|
|
||
| - :ref:`Enhancements <whatsnew_0141.enhancements>` | ||
| - New methods :meth:`~pandas.DataFrame.select_dtypes` to select columns |
There was a problem hiding this comment.
can you add to release.rst as well?
|
Done. |
DOC: clean up 0.14.1 whatsnew file
|
Just wait a moment for the doc build to see if it looks OK, then should be good to go! |
|
just ping when u r satisfied |
|
looking good |
|
pls upload docs when you can! ping and i'll change the html file (or you can if you u want). |
|
seems the offsets (normalize) is in BOTH API and enhancements sections in whatsnew? (its slightly different), did you mean that? |
|
yep, I did that on purpose (because in the enhancement section it is just about the normalize keyword, while in the API it is about the changed behaviour for some offsets). Is it confusing? I can always change it. |
|
I would take out the section in Enhancements and leave the API section. |
|
The entry that is now in Enhancements is the original message, but while cleaning up the whatsnew docs, I first moved it from API changes to Enhancements because it said nothing about an API change but just the introduction of a keyword, but when I looked at the connected issue, I saw there was actually an API change, so added another entry in API changes to explain the actual change .. |
|
ok 2....its just that on a quick read they look very similar |
|
restart the web server to reflect the new docs after you upload
|
|
What do you mean exactly? For the website, or for the docs? |
|
I think if you change the docs, need to restart the web server, it should reflect immediately I think |
|
If I tried it in my browser, it was directly changed (just refreshed the page) |
|
really? did you push a new commit anyhow? |
|
Looking at the upload.py script, and it seems similar command as in doc/make.py So I just build the docs locally and then upload them, all with the make.py script (eg the |
|
it pushes it to the actual server |
|
well, but I suppose doc/make.py does the same thing (it is a similar rsync command to push it to |
|
Did you notice a problem with the website/docs? |
|
they look fine, jus not 100% what you changed |
Highlights should still be written to include here and in the release.rst