CLN: Expose arguments in DataFrame.query #61413
Open
+87
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
May 19, 2025
| @@ -4624,8 +4694,15 @@ def query(self, expr: str, *, inplace: bool = False, **kwargs) -> DataFrame | No | |||
| if not isinstance(expr, str): | |||
| msg = f"expr must be a string to be evaluated, {type(expr)} given" | |||
| raise ValueError(msg) | |||
| kwargs["level"] = kwargs.pop("level", 0) + 1 | |||
| kwargs["target"] = None | |||
| kwargs: Any = { | |||
There was a problem hiding this comment.
It appears to me there is no reason to construct a dict here anymore. Assuming that's correct, can you instead pass these as normal function arugments.
| @@ -401,6 +401,7 @@ Other API changes | |||
| - Index set operations (like union or intersection) will now ignore the dtype of | |||
| an empty ``RangeIndex`` or empty ``Index`` with object dtype when determining | |||
| the dtype of the resulting Index (:issue:`60797`) | |||
| - :meth:`DataFrame.query` does not accept ``**kwargs`` anymore and requires passing keywords for desired arguments (:issue:`61405`) | |||
There was a problem hiding this comment.
Since this is fully backwards compatible, I think we do not need to mention this in the whatsnew.
rhshadrach
changed the title
rhshadrach
changed the title
rhshadrach
added
Clean
expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.