BUG: round on object columns no longer raises a TypeError #61399
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rhshadrach
requested changes
May 19, 2025
There was a problem hiding this comment.
Looking good - can you add a note in the 2.3 whatsnew. I think we should backport this as it's a regression.
cc @mroeschke
| @@ -72,3 +72,9 @@ def test_round_ea_boolean(self): | |||
| tm.assert_series_equal(result, expected) | |||
| result.iloc[0] = False | |||
| tm.assert_series_equal(ser, expected) | |||
|
|
|||
| def test_round_dtype_object(self): | |||
| ser = Series([0.2], dtype="object") | |||
There was a problem hiding this comment.
Can you add a reference to the GitHub issue
rhshadrach
added
Bug
Regression
mroeschke
reviewed
May 19, 2025
| @@ -2814,6 +2814,8 @@ def round(self, decimals: int = 0, *args, **kwargs) -> Series: | |||
| dtype: float64 | |||
| """ | |||
| nv.validate_round(args, kwargs) | |||
| if self._mgr.dtype == "object": | |||
There was a problem hiding this comment.
Suggested change
| if self._mgr.dtype == "object": | |
| if self.dtype == "object": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.